findallfiles hangs

[hakelm]

I am trying to list my files on Ubuntu,  Lazarus 1.9 with
  files:=tstringlist.Create;
  findallfiles(files,'/');
but findallfiles never returns.
I suspect that findallfiles follows links and plays ping-pong with itself.
Is that so or is there any other reason?
How can I get findallfiles to work?
Thanks in advance for any tip.
H

[Bart]

You can try to set the propert FollowSymlinks to False?

Bart

[hakelm]

Thanks,
but I can't see that

procedure FindAllFiles(AList: TStrings; const SearchPath: String;
  SearchMask: String = ''; SearchSubDirs: Boolean = True; DirAttr: Word = faDirectory);
or
function FindAllFiles(const SearchPath: String; SearchMask: String = '';
  SearchSubDirs: Boolean = True): TStringList;

has any parameter FollowSymlinks.
The DirAttr are only faReadOnly, faHidden,faSysFile, faVolumeId,faDirectory,faArchive.
H

[howardpc]

Yes, you need a slightly extended FindAllFiles routine, such as this

Code: Pascal  [Select][+][-]

1. uses FileUtil;
2.  
3. procedure FindAllFiles(AList: TStrings; const SearchPath: String;
4.   SearchMask: String; SearchSubDirs, FollowSymLinks: Boolean; DirAttr: Word); overload;
5. var
6.   Searcher: TListFileSearcher;
7. begin
8.   Searcher := TListFileSearcher.Create(AList);
9.   Searcher.DirectoryAttribute := DirAttr;
10.   Searcher.FollowSymLink := FollowSymLinks;
11.   try
12.     Searcher.Search(SearchPath, SearchMask, SearchSubDirs);
13.   finally
14.     Searcher.Free;
15.   end;
16. end;

[hakelm]

Thanks,
seems to do the trick.
H

[Bart]

Can you file a feature request for that in the bugtracker?

Bart

[hakelm]

I verified the pingpong behaviour by doing

mkdir fs;cd fs;touch ff;ln -s ../fs fl

and then executing

FindAllFiles(li,'/root/fs','*',true,faanyfile);

FindAllFiles actually returns after a while but with the interesting output in li below.
The modification proposed by Bart prevents this behaviour but no links are listed.
It should also be noted that the OnFileFound event is not triggered by TListFileSearcher.DoFileFound.

/root/fs/ff
/root/fs/fl/ff
/root/fs/fl/fl/ff
/root/fs/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff
/root/fs/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/fl/ff