Datasource not disabled

[egsuh]

Hi,
I linked a DBGrid to datasource, and which is to a dataset.
I set datasource.enabled to false, but the DBGrid still shows the content of the dataset.
Please confirm this.
Regards,

[GAN]

You must close the DataSet if you want to empty the TDBgrid.
I think this behavior is fine.

[egsuh]

You must close the DataSet if you want to empty the TDBgrid.
I think this behavior is fine.

I don't think this is fine. When I change the content of a TDataset  programatically, if there are any linked TDataSource and TDataControls, this behavior slows down the operation by large, because every change in the TDataSet must be reflected in the TDataControls.

Just disabling TDataSource should prevent the content on the TDataControls from being refreshed. When the operation is finished, just enabling TDataSource would show the final result.

Of course I can do this by setting TDataSource.DataSet to nil and returning to the TDataSet, but the purpose of TDataSource.Enabled property is what I'm trying to do. 

[valdir.marcos]

You must close the DataSet if you want to empty the TDBgrid.
I think this behavior is fine.

I don't think this is fine. When I change the content of a TDataset  programatically, if there are any linked TDataSource and TDataControls, this behavior slows down the operation by large, because every change in the TDataSet must be reflected in the TDataControls.

Just disabling TDataSource should prevent the content on the TDataControls from being refreshed. When the operation is finished, just enabling TDataSource would show the final result.

Of course I can do this by setting TDataSource.DataSet to nil and returning to the TDataSet, but the purpose of TDataSource.Enabled property is what I'm trying to do.

You should do this:

Code: Pascal  [Select][+][-]

1.   SQLQuery.DisableControls;
2.   ...
3.   SQLQuery.EnableControls;

[egsuh]

Yes, I know there are many ways to achieve my purpose.
I'm saying that TDataSource.Enabled is designed to that purpose, and it should be implemented because other things may depend on the TDataSource as well, not only enabling/disabling controls. For example, I may write some codes within TDataSource.OnChange event, and sometimes I do not want these to be executed. Yes, I can write TDataSource.OnChange := nil, but TDataSource.Enabled must be enabled.


I tested following line with a small Delphi program, which exactly does what I expect.

Code: Pascal  [Select][+][-]

1.   datasource1.Enabled := not datasource1.Enabled;

[taazz]

The help file agrees with you, a quick look on the source also shows that enabled is not used in any of the event processing code, report it on the bug tracker.