Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
Optimize TDeque.IncreaseCapacity
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
JEDI error but unit compi...
by
bobonwhidbey
[
Today
at 07:10:38 pm]
how to search in rxmemory...
by
korba812
[
Today
at 06:57:30 pm]
Dynarray initialization p...
by
Thaddy
[
Today
at 06:30:12 pm]
Controlling the behavior ...
by
1HuntnMan
[
Today
at 06:09:27 pm]
how to change the color f...
by
Thaddy
[
Today
at 06:01:15 pm]
Project fails on run but ...
by
dseligo
[
Today
at 05:30:42 pm]
Zeos components. Had to c...
by
Fantablup
[
Today
at 04:17:13 pm]
[SOLVED] Completion box s...
by
furious programming
[
Today
at 04:12:26 pm]
[LAMW] How to create a ca...
by
af0815
[
Today
at 03:48:16 pm]
Complex package installat...
by
wp
[
Today
at 03:38:16 pm]
A "leisure" question on W...
by
gidesa
[
Today
at 03:17:10 pm]
Curling Pythagoras Tree: ...
by
AlexTP
[
Today
at 03:07:53 pm]
[SOLVED] Combined pointer...
by
CM630
[
Today
at 02:48:41 pm]
Using KeyPress event, how...
by
Zvoni
[
Today
at 02:24:42 pm]
a Unit problem?
by
Thaddy
[
Today
at 01:56:12 pm]
Understanding and adjusti...
by
ArchChem
[
Today
at 12:58:12 pm]
Any upgrades to fpWeb pag...
by
marcov
[
Today
at 12:50:25 pm]
Help needed with Cairo / ...
by
Roland57
[
Today
at 12:25:16 pm]
Configure JCF messages
by
DomingoGP
[
Today
at 11:26:55 am]
IDE instability on Raspbe...
by
rvk
[
Today
at 10:37:14 am]
Boleeman's projects are p...
by
AlexTP
[
Today
at 10:18:04 am]
Your best UI design - con...
by
circular
[
Today
at 09:36:11 am]
ZeosDBO and querys using ...
by
Zvoni
[
Today
at 09:27:17 am]
STARS with line border st...
by
Boleeman
[
Today
at 09:13:29 am]
A button require administ...
by
Fibonacci
[
Today
at 05:57:21 am]
« previous
next »
Print
Pages:
1
[
2
]
Author
Topic: Optimize TDeque.IncreaseCapacity (Read 7708 times)
Thaddy
Hero Member
Posts: 14204
Probably until I exterminate Putin.
Re: Optimize TDeque.IncreaseCapacity
«
Reply #15 on:
October 14, 2018, 08:06:38 pm »
Quote from: Alextp on October 14, 2018, 07:53:17 pm
What about my change?
The many branches in that code would make it slower than the current implementation.
Either use a look-up or stick to your original plan and increase the initial size to say, 4 or 5.
You have to devise some tests...
Logged
Specialize a type, not a var.
Artem3213212
New member
Posts: 7
Re: Optimize TDeque.IncreaseCapacity
«
Reply #16 on:
October 14, 2018, 08:45:12 pm »
Quote from: Alextp on October 14, 2018, 07:53:17 pm
What about my change?
Ok, but it make some bad work with memory pages. Correct version:
Code: Pascal
[Select]
[+]
[-]
procedure
TDeque
.
IncreaseCapacity
;
const
// if size is small, multiply by 2;
// if size bigger but <256M, inc by 1/8*size;
// otherwise inc by 1/16*size
cSizeSmall
=
1
*
1024
*
1024
;
cSizeBig
=
256
*
1024
*
1024
;
var
i
,
OldEnd
:
SizeUInt
;
DataSize
:
SizeUInt
;
begin
OldEnd
:
=
FCapacity
;
DataSize
:
=
FCapacity
*
SizeOf
(
T
)
;
if
FCapacity
=
0
then
FCapacity
:
=
4
else
if
DataSize<cSizeSmall
then
FCapacity
*=
2
else
if
DataSize<cSizeBig
then
FCapacity
+=
FCapacity
div
8
and
$FFFFF000
else
FCapacity
+=
FCapacity
div
16
and
$FFFFF000
;
SetLength
(
FData
,
FCapacity
)
;
if
(
FStart>
0
)
then
for
i
:
=
0
to
FStart
-
1
do
FData
[
OldEnd
+
i
]
:
=
FData
[
i
]
;
end
;
«
Last Edit: October 14, 2018, 08:55:41 pm by Artem3213212
»
Logged
AlexTP
Hero Member
Posts: 2386
Re: Optimize TDeque.IncreaseCapacity
«
Reply #17 on:
October 14, 2018, 08:48:59 pm »
Thaddy,
branches are needed here, to check: n in one of ranges:
[0..1M] [1M..256M] [256M..inf]
Logged
CudaText editor
-
ATSynEdit
-
More from me
ASerge
Hero Member
Posts: 2222
Re: Optimize TDeque.IncreaseCapacity
«
Reply #18 on:
October 17, 2018, 09:29:25 pm »
I like TFPList.Expand
Logged
Bart
Hero Member
Posts: 5275
Re: Optimize TDeque.IncreaseCapacity
«
Reply #19 on:
January 06, 2021, 12:57:17 pm »
These changes to TDeque have broken it.
If the array isn't doubled (in IncreaseCapacity) then it is not circular anymore (the calculation of the positions wehre to put/get values doesn't match anymore.
See
Issue #38306
.
Bart
Logged
Print
Pages:
1
[
2
]
« previous
next »
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
Optimize TDeque.IncreaseCapacity
TinyPortal
© 2005-2018